repair_timing improvements
#1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't catch errors from repair_timing. There are many reasons it might fail and reporting "utilization limit is reached" is just confusing. - Handle options with a list.
|
These were a couple of suggestions from @jjcherry56 |
donn
approved these changes
May 29, 2022
growly
pushed a commit
to growly/openlane
that referenced
this pull request
May 31, 2022
~ Don't catch errors from repair_timing. There are many reasons it might fail and reporting "utilization limit is reached" is just confusing. ~ Handle arguments with an arg_list Suggested by @jjcherry56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~ Don't catch errors from repair_timing. There are many reasons it might
fail and reporting "utilization limit is reached" is just confusing.
~ Handle arguments with an arg_list
Suggested by @jjcherry56