Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hard-coded Paths in Sample Designs #1083

Merged
merged 1 commit into from
May 6, 2022
Merged

Remove Hard-coded Paths in Sample Designs #1083

merged 1 commit into from
May 6, 2022

Conversation

cbalint13
Copy link
Contributor

@cbalint13 cbalint13 commented May 6, 2022

PART1

Avoid hardcoded path in the setups of the sample designs.
Design configs should be consistent regarding issues with path hard-coding.


A sample effort of system-wide OpenLane distributable is available here.

The structure of distributables:

$ rpm -ql openlane
/usr/bin/openlane-flow
/usr/share/openlane/flow.tcl
/usr/share/openlane/configuration/{..}
/usr/share/openlane/scripts/{..}
/usr/share/tcl8.6/openlane-tcl_commands/*
/usr/share/tcl8.6/openlane-utils/*
/usr/share/doc/openlane/{..}

$ rpm -ql openlane-designs
/usr/share/openlane/designs/{..,}

$ rpm -ql efabless-open-pdks-sky130_fd_sc_hd
/usr/share/pdk/sky130{A,B}/{...}
  1. The /usr/bin/openlane-flow is system-wide wrap to flow.tcl (the openlane- suffix avoids confusion).
  2. Modules in /usr/share/tcl8.6/ are by default in system reach on any distro, they are picked up anytime.
  3. The /usr/share/openlane/ is also system wide and picked up by /usr/bin/openlane-flow itself.
  4. The PDK (separate packages) is also in standard stystem path of /usr/share/pdk/sky130{A,B}

Details of packaging:

Thank you,
~Cristian

@donn @vvbandeira @proppy
Cc @maliberty

@donn donn self-requested a review May 6, 2022 12:32
Copy link
Collaborator

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entirely reasonable and I thought I did this. Thank you.

@donn donn changed the title [System Wide OpenLane] Avoid hardcoded paths in sample designs. Remove Hard-coded Paths in Sample Designs May 6, 2022
@donn donn merged commit 47c9f22 into The-OpenROAD-Project:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants