Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add facility to package failed runs #424

Closed
maliberty opened this issue Jun 5, 2021 · 4 comments
Closed

Add facility to package failed runs #424

maliberty opened this issue Jun 5, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@maliberty
Copy link
Member

In OpenROAD-flow-scripts the 'make issue' facility makes it easy to package up all necessary files to reproduce a problem in order to reproduce an issue. OpenLane needs a similar capability. See the on-going discussion in The-OpenROAD-Project/OpenROAD#703.
@donn donn added the enhancement New feature or request label Jun 6, 2021
@donn
Copy link
Collaborator

donn commented Jun 6, 2021

I'll be honest, I have no idea what on earth is going on here: https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/blob/b549b82ff7a3c004a0117ebea2ef970f2d4c7207/flow/util/utils.mk#L57

The (unofficial) ruby script I made simply tries to extract the variables and files, then replace them with resolved values. Does this do something similar?

@maliberty
Copy link
Member Author

It produces a tgz with runme script that (1) sources a script that captures all the envars set by make and (2) invokes openroad on the proper tcl file to reproduce the step that is failing. That tgz is a complete capture of the problem and is trivial for a developer to unpack and run.

@donn
Copy link
Collaborator

donn commented Jun 7, 2021

Huh. I like the idea of the runner script being the one to set the environment variables. I'll look into it.

donn added a commit to donn/openlane that referenced this issue Jun 7, 2021
@donn
or_issue.py (RE: The-OpenROAD-Project#424)
e4fe3fb
donn added a commit that referenced this issue Jun 8, 2021
@donn
or_issue.py (RE: #424) (#428)
cf419c9 
* or_issue.py (RE: #424)

* Reflect changes based on @maliberty's review

* 66 -> os.EX_NOINPUT
@donn
Copy link
Collaborator

donn commented Jun 8, 2021

Closed in #428.

@donn donn closed this as completed Jun 8, 2021
donn added a commit to donn/openlane that referenced this issue Jul 2, 2021
@donn
or_issue.py (RE: The-OpenROAD-Project#424) (The-OpenROAD-Project#428)
8f9a0f4 
* or_issue.py (RE: The-OpenROAD-Project#424)

* Reflect changes based on @maliberty's review

* 66 -> os.EX_NOINPUT
donn added a commit that referenced this issue Jul 7, 2021
@donn
or_issue.py (RE: #424) (#428)
5731e51 
* or_issue.py (RE: #424)

* Reflect changes based on @maliberty's review

* 66 -> os.EX_NOINPUT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maliberty @donn