Swap open-vs-close tag order when converting Text to markup. #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm torn on whether this is a pleasingly simple solution or a solution that's too simple to possibly be correct. Still, it makes the test pass, so it'll do as a first cut while I decide if I want to make a second, more complex run at it. (Possibly track the order open-tags were rendered to ensure that multiple close-tags at a given offset get popped off in reverse open-tag order?)
2 tasks
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3163 +/- ##
==========================================
- Coverage 98.30% 98.28% -0.03%
==========================================
Files 74 74
Lines 8038 8043 +5
==========================================
+ Hits 7902 7905 +3
- Misses 136 138 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Not convinced this is the solution. Suspect it will only work for the trivial case. More tests might convince me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Fixes #3155.
(I'm torn on whether this is a pleasingly simple solution or a solution that's too simple to possibly be correct. Still, it makes the test pass while making some improvement on making sure existing tags get closed before new ones are opened. I made an attempt at a more sophisticated effort to more closely track tag opening order and it took things to la-la-land, so I abandoned that and am calling this good enough.)