Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax tests for old pygments #2851

Merged
merged 1 commit into from
Mar 4, 2023
Merged

relax tests for old pygments #2851

merged 1 commit into from
Mar 4, 2023

Conversation

willmcgugan
Copy link
Collaborator

Relax our dependancy on Pygments. To address issues like these:

Fixes #2810

Not our fault, per se. But that doesn't mean we aren't going to keep getting issues about it.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.07 ⚠️

Comparison is base (c2df987) 98.38% compared to head (42e1ec9) 98.32%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2851      +/-   ##
==========================================
- Coverage   98.38%   98.32%   -0.07%     
==========================================
  Files          74       74              
  Lines        7930     7926       -4     
==========================================
- Hits         7802     7793       -9     
- Misses        128      133       +5     
Flag Coverage Δ
unittests 98.32% <81.81%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/syntax.py 98.48% <50.00%> (-0.91%) ⬇️
rich/pretty.py 96.41% <83.33%> (-0.12%) ⬇️
rich/console.py 98.04% <100.00%> (+<0.01%) ⬆️
rich/text.py 99.48% <100.00%> (ø)
rich/traceback.py 95.45% <100.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willmcgugan willmcgugan merged commit fa09487 into master Mar 4, 2023
@willmcgugan willmcgugan deleted the relax-pygments branch March 4, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: JupyterMixin has different default repr in the console
2 participants