Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving tests in test_cells and test_pick #2786

Merged
merged 4 commits into from
Mar 4, 2023
Merged

improving tests in test_cells and test_pick #2786

merged 4 commits into from
Mar 4, 2023

Conversation

andrehora
Copy link
Contributor

@andrehora andrehora commented Jan 29, 2023 •
edited
Loading

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

It seems that test_cells misses some inputs like boundary cases. Those are important to avoid regressions. I updated test_cell_len_long_string and created test_cell_len_short_string to overcome this possible issue.

Also improved test_pickto cover untested inputs of pick_bool.

@andrehora andrehora changed the title improving tests in test_cells improving tests in test_cells and test_pick Jan 29, 2023
willmcgugan
willmcgugan requested changes Jan 29, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@andrehora andrehora requested a review from willmcgugan January 30, 2023 18:43
@willmcgugan willmcgugan merged commit 3588894 into Textualize:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrehora @willmcgugan