Substituting plain headed box when show_header=False on Table #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
commented
Jun 7, 2022
| @@ -14,7 +14,6 @@ repos: | |||
| - id: check-yaml | |||
| - id: end-of-file-fixer | |||
| - id: mixed-line-ending | |||
| - id: trailing-whitespace | |||
There was a problem hiding this comment.
This incorrectly removed some whitespace inside a multiline string (inside a Box), which led to errors.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
- Coverage 98.88% 98.76% -0.13%
==========================================
Files 73 73
Lines 7629 7690 +61
==========================================
+ Hits 7544 7595 +51
- Misses 85 95 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
willmcgugan
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Ensure that if the user passes
show_header=FalsetoTable, then we don't use aBoxwhich assumes the first row is a header row.(Note the examples below aren't of the exact same table, only the first row of the box is relevant anyway)
After
The first line is smooth because
show_header=False, so the box used was updated to one that doesn't use different header edges.Before
The first line uses thicker lines, because the HEAVY_HEAD box is used by default, even though there's no header.
Fixes #2312