feat(react,vue,ios,android): add waterfall component for hippy #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoomchan-cxj
requested review from
churchill-zhang,
ilikethese,
ozonelmy and
siguangli
as code owners
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 61.35% 61.41% +0.06%
==========================================
Files 29 29
Lines 1876 1879 +3
==========================================
+ Hits 1151 1154 +3
Misses 725 725
Continue to review full report at Codecov.
|
|
|
zoomchan-cxj
force-pushed
the
feature/waterfall1
branch
2 times, most recently
from
a491c05 to
752dae3
Compare
Co-authored-by: genesisli <genesisli@tencent.com>
zoomchan-cxj
force-pushed
the
feature/waterfall1
branch
from
752dae3 to
e8e03af
Compare
zoomchan-cxj
changed the title
siguangli
approved these changes
Aug 18, 2021
zoomchan-cxj
added a commit
that referenced
this pull request
Sep 10, 2021
* feat: add waterfall component for hippy * feat(android): make WaterfallView extends HippyListView * feat(android): support 'animated' for scrollToXXX * feat(vue): demo add scrollToXXX * feat(android): add onScroll event params * feat(ios):fix scrollToIndex bug * feat(android): fix scrollToIndex with anim * feat(vue): perf vue waterfall component&demo * feat(react): add waterfall component * feat(react): add waterfall component * refactor(core): build example * fix(android): water fall view reuse error * feat(android): change the onEndReached event send time * feat(android): change the water fall view padding logic * feat(android): change the water fall view padding logic * feat(react): add react waterfall document * feat(ios): improve waterfall item reuse proxy (#1) Co-authored-by: genesisli <genesisli@tencent.com> * feat(ios): fix bug that HippyWaterfallView's bridge isn't assigned * docs(waterfall): add waterfall doc * docs(waterfall): add waterfall doc * chore(build): build react example Co-authored-by: JerryChu <528994690@qq.com> Co-authored-by: genesisli <genesisli@tencent.com> Co-authored-by: derekazhang(张爱民) <derekazhang@tencent.com> Co-authored-by: xilinzheng <xilinzheng@tencent.com> Co-authored-by: hengyangji <hengyangji@tencent.com> Co-authored-by: sweetPotatoZheng <72075059+sweetPotatoZheng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: