add NSAttributedString attributes support for links, support UIColor … #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(not just for Foreground)
|
before, you had to write this tedious mess: self.activeLinkAttributes = @{
(NSString *)kCTUnderlineStyleAttributeName:
@NO,
kTTTBackgroundFillColorAttributeName:
(__bridge id)[[UIColor colorWithWhite:0 alpha:0.3] CGColor],
kTTTBackgroundStrokeColorAttributeName:
(__bridge id)[[UIColor colorWithWhite:1 alpha:0.5] CGColor],
kTTTBackgroundLineWidthAttributeName:
@1,
kTTTBackgroundCornerRadiusAttributeName:
@4
};after, you can just simply do: self.activeLinkAttributes = @{
NSUnderlineStyleAttributeName : @NO,
NSBackgroundColorAttributeName : [UIColor colorWithWhite:0 alpha:0.3],
kTTTBackgroundStrokeColorAttributeName : [UIColor colorWithWhite:1 alpha:0.5],
kTTTBackgroundLineWidthAttributeName : @1,
kTTTBackgroundCornerRadiusAttributeName : @4
}; |
| return [color isKindOfClass:[UIColor class]] ? [color CGColor] : (__bridge CGColorRef)color; | ||
| } | ||
|
|
||
| static inline CTFontRef ctFontRefFromUIFont(UIFont * font) { |
There was a problem hiding this comment.
Should ct be CT in this function name?
|
This looks great, @galambalazs I added a few minor suggestions. |
|
Sure whatever way you want to do it. You can either merge it and add your own changes, or simply do your own PR. I doubt I'll have time to edit this PR in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(not just for Foreground)
Add support for the following attributes for links (default, active, inactive):
Also uniformly support
UIColorfor attribute values not just for Foreground color (as it was previously).