Allow individual removal of users instead of removing all users without vote #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiloAschebrock
force-pushed
the
individually-remove-users
branch
from
4d463aa to
5fe5b86
Compare
1 task
ThiloAschebrock
force-pushed
the
individually-remove-users
branch
2 times, most recently
from
bddffe4 to
3bc860d
Compare
…ut vote Signed-off-by: Thilo Aschebrock <thilo.aschebrock@tngtech.com>
Signed-off-by: Thilo Aschebrock <thilo.aschebrock@tngtech.com>
ThiloAschebrock
force-pushed
the
individually-remove-users
branch
from
3bc860d to
35b7cf2
Compare
lukastaegert
reviewed
Nov 4, 2022
There was a problem hiding this comment.
Amazing feature! Only thing for me is that I find the kick button very prominent in the current color scheme, especially since you should not play around with this button lightly. My suggestion would be to change its color to match the cards, i.e. gray background + blue icon that becomes white on blue when hovered. What do you think?
Otherwise, code looks good to me.
|
Yes, that's a great point. I will give your suggestions a try - let's see how it looks and feels. |
Signed-off-by: Thilo Aschebrock <thilo.aschebrock@tngtech.com>
|
The kick button is now less prominent by implementing your suggestion in dcc182a: |
lukastaegert
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88
TODO: