feat(allocators): RecycleFBA: configurable inherent thread safety #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses the same approach as the GPA
previously the init function was broken because it made a copy of the allocator and contained a pointer to the original copy which was discarded from the stack also, even after fixing that, when GeyserWriter would contain a mutable pointer to itself. the RecycleFBA should really be allocated on the stack. when the data is actually a part of the GeyserWriter struct, it means you have a struct that may be "const" but is still mutable because it contains a mutable pointer to itself. this violates aliasing assumptions and maybe it can trigger UB?
dadepo
reviewed
Sep 1, 2024
dadepo
reviewed
Sep 1, 2024
0xNineteen
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements thread safety within RecycleFBA by acquiring and releasing the lock in the alloc, free, and resize functions. Code that uses the allocator no longer needs to directly access the mutex in the RecycleFBA
Thread safety is configurable using the same approach as the GPA. The type takes a comptime config parameter. Thread safety is on by default if multithreading is supported by the platform.
pinging @dadepo for visibility since he is also using this allocator in his branch.