Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodiscover resource's model interfaces and deprecate explicit configuration #97

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Autodiscover resource's model interfaces and deprecate explicit configuration #97

merged 1 commit into from
Jun 18, 2019
+371 −110

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jun 13, 2019 •
edited
Loading

Fixes #94, solution described in #94 (comment).

@pamil pamil mentioned this pull request Jun 13, 2019
Open
@pamil pamil merged commit 1b3a89f into Sylius:master Jun 18, 2019
@pamil pamil deleted the doctrine-target-entities-resolver branch June 18, 2019 05:18
lchrusciel
lchrusciel reviewed Jun 21, 2019
View reviewed changes
src/Bundle/spec/DependencyInjection/Compiler/Helper/TargetEntitiesResolverSpec.php
use Sylius\Bundle\ResourceBundle\Tests\Fixtures\MammalInterface;
use Sylius\Bundle\ResourceBundle\Tests\Fixtures\Resource;

class TargetEntitiesResolverSpec extends ObjectBehavior
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing final :)

@Zales0123 Zales0123 mentioned this pull request Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel

@bartoszpietrzak1994 bartoszpietrzak1994

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doctrine class metadata not found for extended interface
3 participants
@pamil @lchrusciel @bartoszpietrzak1994