Add DI for Main controller, providers and processors #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
poc-main-controller
branch
2 times, most recently
from
2c28a3c to
22ed7e1
Compare
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
Prometee
reviewed
Dec 15, 2023
src/Component/src/State/Processor/PostEventDispatcherProcessor.php
Outdated
Show resolved
Hide resolved
Prometee
reviewed
Dec 15, 2023
src/Component/src/State/Processor/PreEventDispatcherProcessor.php
Outdated
Show resolved
Hide resolved
Prometee
reviewed
Dec 15, 2023
src/Component/src/Symfony/Serializer/State/SerializeProcessor.php
Outdated
Show resolved
Hide resolved
|
Thx @Prometee That's a draft and I need that to debug ;) Of course I will remove these dump methods when it will be ready to review, but I think I will split that into few smaller PRs. |
This was referenced Dec 15, 2023
Merged
Merged
Merged
diimpp
reviewed
Dec 17, 2023
|
|
||
| public function __invoke(Request $request): Response | ||
| { | ||
| $operation = $this->operationInitiator->initializeOperation($request); |
There was a problem hiding this comment.
On side note,
--- /** @var string|null $operationName */
--- $operationName = $request->attributes->get('_route');
+++ $operationName = $request->attributes->getString('_route', null);
lchrusciel
added a commit
that referenced
this pull request
Dec 18, 2023
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes (but on non-released feature) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from #817 Commits ------- f0ec95e Fix serialize processor
lchrusciel
added a commit
that referenced
this pull request
Dec 18, 2023
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes (but on non-released feature) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from #817 Commits ------- 2827646 Fix flash processor
lchrusciel
added a commit
that referenced
this pull request
Dec 18, 2023
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes (but on non-released feature) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from #817 Commits ------- 460da65 Fix event dispatcher provider
loic425
force-pushed
the
poc-main-controller
branch
2 times, most recently
from
10b6eb6 to
32a1fe7
Compare
This was referenced Dec 18, 2023
Merged
Co-authored-by: Łukasz Chruściel <lchrusciel@gmail.com>
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
loic425
force-pushed
the
poc-main-controller
branch
from
a8283e5 to
b6ed881
Compare
GSadee
approved these changes
Jan 26, 2024
Comment on lines
+15
to
+19
| <imports> | ||
| <import resource="state/processor.xml" /> | ||
| <import resource="state/provider.xml" /> | ||
| <import resource="state/**/*.xml" /> | ||
| </imports> |
There was a problem hiding this comment.
This is a small thing, but I suggested removing these imports and add a generic one to services.xml
|
Thanks, Loïc! 🎉 |
GSadee
pushed a commit
to Sylius/Resource
that referenced
this pull request
Feb 2, 2024
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes (but on non-released feature) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from Sylius/SyliusResourceBundle#817 Commits ------- f0ec95ecdabcabf7a1ee0b3e7792a4c381f18c3c Fix serialize processor
GSadee
pushed a commit
to Sylius/Resource
that referenced
this pull request
Feb 2, 2024
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes (but on non-released feature) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from Sylius/SyliusResourceBundle#817 Commits ------- 282764628d4f295ede138d628d9150f3feeef036 Fix flash processor
GSadee
pushed a commit
to Sylius/Resource
that referenced
this pull request
Feb 2, 2024
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes (but on non-released feature) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from Sylius/SyliusResourceBundle#817 Commits ------- 460da65f30972475a0188ecc388c85b37563b824 Fix event dispatcher provider
GSadee
pushed a commit
to Sylius/Resource
that referenced
this pull request
Feb 2, 2024
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from Sylius/SyliusResourceBundle#817 Commits ------- b6986256b184f895dc449c4af62cf646f64334b3 Add main controller 750260a524ab4d4cf123fbdf99de09b3c0340d3b Add PHPUnit tests 93857ed17b81dcddba560380aff9217657c0d765 Use a new Runtime exception
GSadee
pushed a commit
to Sylius/Resource
that referenced
this pull request
Feb 2, 2024
…r (loic425) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from Sylius/SyliusResourceBundle#817 Commits ------- ca8c216629206c415c71d3c23096bc7351c2add7 Replace by into bulk aware processor
GSadee
pushed a commit
to Sylius/Resource
that referenced
this pull request
Feb 2, 2024
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes (but on non-released feature) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from Sylius/SyliusResourceBundle#817 Commits ------- dc9eed2489588eaa2255c2201d95f2acd19e7b73 Fix respond processor
GSadee
pushed a commit
to Sylius/Resource
that referenced
this pull request
Feb 2, 2024
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from Sylius/SyliusResourceBundle#817 It was PreEventDispatcherProcessor but I think it's a better name now. I've decided to split https://github.com/Sylius/SyliusResourceBundle/blob/1.11/src/Component/src/State/Processor/EventDispatcherProcessor.php into two processors, so this one is the first part of the split. This processor allows user switching from resource controller to this new system easily. But we will be able to deprecate this event in the future. Commits ------- e87b8863a5870e40462cb3f77fcefb3a347d72c4 Dispatch pre write event processor 62fa18f5d5705399bada3e798f2852171ba1a3d7 Rename a test
GSadee
pushed a commit
to Sylius/Resource
that referenced
this pull request
Feb 2, 2024
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Extracted from Sylius/SyliusResourceBundle#817 Commits ------- 09320aa4d2928d1b40d825fba1cb194a424812ee Write processor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On browsing resources
On creating a new resource
On invalid creation
On deleting a single resource
On delete multiple resources
