Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some namespaces on Symfony event listener #772

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Move some namespaces on Symfony event listener #772

merged 3 commits into from
Nov 9, 2023
+44 −44

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Nov 4, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Based on #767

@loic425 loic425 requested a review from a team as a code owner November 4, 2023 15:01
@loic425 loic425 changed the title Move component namespace/symfony/event listener @loic425 Move some namespaces on Symfony event listener Nov 4, 2023
@loic425 loic425 changed the title @loic425 Move some namespaces on Symfony event listener Move some namespaces on Symfony event listener Nov 4, 2023
@loic425 loic425 force-pushed the move-component-namespace/symfony/event-listener branch from eb65d39 to 2fa3b40 Compare November 7, 2023 20:14
@loic425 loic425 force-pushed the move-component-namespace/symfony/event-listener branch from 2fa3b40 to d923d80 Compare November 8, 2023 08:43
oallain
oallain approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

@lchrusciel lchrusciel merged commit e1dc2df into Sylius:1.11 Nov 9, 2023
@lchrusciel
Copy link
Contributor

Thank you, @loic425!

@loic425 loic425 deleted the move-component-namespace/symfony/event-listener branch November 9, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp

@lchrusciel lchrusciel

@oallain oallain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@loic425 @lchrusciel @diimpp @oallain