Remove Component namespace on state #762
Merged
+97
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Oct 25, 2023
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
|
@diimpp Also introduced in 1.11 alpha |
diimpp
approved these changes
Oct 25, 2023
| @@ -73,7 +73,7 @@ function it_throws_an_exception_when_configured_provider_is_not_a_provider_insta | |||
| $locator->has('\stdClass')->willReturn(true); | |||
| $locator->get('\stdClass')->willReturn(new \stdClass()); | |||
|
|
|||
| $this->shouldThrow(new \InvalidArgumentException('Expected an instance of Sylius\Component\Resource\State\ProviderInterface. Got: stdClass')) | |||
| $this->shouldThrow(new \InvalidArgumentException('Expected an instance of Sylius\Resource\State\ProviderInterface. Got: stdClass')) | |||
There was a problem hiding this comment.
As idea
Suggested change
| $this->shouldThrow(new \InvalidArgumentException('Expected an instance of Sylius\Resource\State\ProviderInterface. Got: stdClass')) | |
| $this->shouldThrow(new \InvalidArgumentException(sprintf('Expected an instance of %s. Got: %s', ProviderInterface::class, \stdClass::class))) |
There was a problem hiding this comment.
Yeah, I think I've read that it's better not to use constants and things like that in specs/tests.
@lchrusciel @Zales0123?
There was a problem hiding this comment.
I don't have a strong opinion about that. Will the test still make sense if we would move provider to other namespace? Yup. Both approaches are fine for me
| @@ -73,7 +73,7 @@ function it_throws_an_exception_when_configured_processor_is_not_a_processor_ins | |||
| $locator->has('\stdClass')->willReturn(true); | |||
| $locator->get('\stdClass')->willReturn(new \stdClass()); | |||
|
|
|||
| $this->shouldThrow(new \InvalidArgumentException('Expected an instance of Sylius\Component\Resource\State\ProcessorInterface. Got: stdClass')) | |||
| $this->shouldThrow(new \InvalidArgumentException('Expected an instance of Sylius\Resource\State\ProcessorInterface. Got: stdClass')) | |||
There was a problem hiding this comment.
As idea
Suggested change
| $this->shouldThrow(new \InvalidArgumentException('Expected an instance of Sylius\Resource\State\ProcessorInterface. Got: stdClass')) | |
| $this->shouldThrow(new \InvalidArgumentException(sprintf('Expected an instance of %s. Got: %s', ProcessorInterface::class, \stdClass::class))) |
loic425
force-pushed
the
move-component-namespace/state
branch
from
438cfb1 to
d74db52
Compare
diimpp
approved these changes
Oct 30, 2023
|
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.