Add support for Symfony 6 #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Apr 15, 2022
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | I hope no |
| Deprecations? | no |
| Related tickets | #400 |
| License | MIT |
loic425
force-pushed
the
maintenance/symfony-6
branch
2 times, most recently
from
c7f8d6a to
f4ee597
Compare
loic425
force-pushed
the
maintenance/symfony-6
branch
2 times, most recently
from
3be0f53 to
eee87ed
Compare
loic425
force-pushed
the
maintenance/symfony-6
branch
from
a1788ff to
43d63f3
Compare
Co-authored-by: Łukasz Chruściel <lchrusciel@gmail.com>
This PR was merged into the maintenance/symfony-6 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially #400 | License | MIT Commits ------- 6e7b7a8 Fix Phpspec for Symfony 6 0c81c2c Commit suggestions 0cb7c9a Apply suggestions from code review 1d165a0 Fix eb465b8 Simplify tests
…425) This PR was merged into the maintenance/symfony-6 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes (for Symfony 6) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially #400 | License | MIT Commits ------- dad9a5c Fix wrong error from Psalm 4a3b340 Make Twig public to fix resource controller c95b968 Fix coding standard dc22e5b Add a note to remove Twig pass on sylius resource bundle 2.0
lchrusciel
reviewed
Apr 20, 2022
| return $result; | ||
| } | ||
| } | ||
| } elseif (Kernel::MAJOR_VERSION === 5) { |
There was a problem hiding this comment.
We should remove sf4 acl
lchrusciel
approved these changes
Apr 20, 2022
lchrusciel
added
Feature
|
Thanks, Loïc! 🎉 |
lchrusciel
added a commit
that referenced
this pull request
Apr 20, 2022
…ack of its support (lchrusciel) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Continuation of #430 and #428 | License | MIT Commits ------- 1b0501c [Maintenance] Drop Sf4 ACL on parameters class due to lack of its support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.