Revert "Revert "Bump Pagerfanta from 2.x to 3.x"" #417
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lchrusciel
commented
Apr 11, 2022
lchrusciel
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | reverts #416 for higher branches |
| License | MIT |
lchrusciel
force-pushed
the
revert-416-revert-381-pagerfanta-3
branch
from
c593a6a to
1645101
Compare
lchrusciel
force-pushed
the
revert-416-revert-381-pagerfanta-3
branch
from
1645101 to
b658b28
Compare
loic425
requested changes
Apr 11, 2022
| @@ -58,6 +58,7 @@ | |||
| "doctrine/orm": "^2.5", | |||
| "lchrusciel/api-test-case": "^5.0", | |||
| "matthiasnoback/symfony-dependency-injection-test": "^4.2.1", | |||
| "pagerfanta/pagerfanta": "^3.0", | |||
There was a problem hiding this comment.
for now I suggest you to move it on main requirements. We'll handle the "optional" requirements later on next release
There was a problem hiding this comment.
it was just a revert to make our branches green again, so I would go with it for now. But I agree, that 1.9 needs this. The question is should be part of this PR?
There was a problem hiding this comment.
Hum good idea to make this change in another "Fix" PR.
GSadee
approved these changes
Apr 11, 2022
loic425
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.