Add a simple way to use the new service entity repository #330
Conversation
loic425
force-pushed
the
feature/allow-using-service-entity-repository
branch
2 times, most recently
from
b52eb7b to
9d5df06
Compare
|
Co-authored-by: Łukasz Chruściel <lchrusciel@gmail.com>
loic425
force-pushed
the
feature/allow-using-service-entity-repository
branch
from
8f1046c to
4f8f809
Compare
I think it has to be here too |
| @@ -70,3 +70,5 @@ services: | |||
| - | |||
| name: doctrine.event_subscriber | |||
| connection: default | |||
|
|
|||
| App\Repository\ComicBookRepository: null | |||
There was a problem hiding this comment.
Wouldn't App\Repository\ComicBookRepository: ~ work as well? It looks better, definitely 😄
There was a problem hiding this comment.
Yes, but Symfony best practice is to set "null" instead of "~"
https://github.com/symfony/recipes/#validation
| * @method QueryBuilder createQueryBuilder(string $alias, string $indexBy = null) | ||
| * @method ?object find($id, $lockMode = null, $lockVersion = null) | ||
| */ | ||
| trait ResourceRepositoryTrait |
There was a problem hiding this comment.
What would be awesome, is to create php unit test for this trait with usage of anonymous class. But I can live with the current solution. Also, it appears that it may be cumbersome to do such a test
| * @property ClassMetadata $_class | ||
| * | ||
| * @method QueryBuilder createQueryBuilder(string $alias, string $indexBy = null) | ||
| * @method ?object find($id, $lockMode = null, $lockVersion = null) |
There was a problem hiding this comment.
I wonder if we shouldn't declare these methods as abstract, to force contract
| @@ -0,0 +1,106 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
| @@ -0,0 +1,21 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
|
Thank you, Loïc! 🎉 |
When using
bin/console make:entitycommand, a repository is automatically generated extending ServiceEntityRepository.I propose with this PR a simple way to keep using this generated repository with two simple changes: