Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test app #234

Merged
merged 13 commits into from
Dec 7, 2020
Merged

Refactor test app #234

merged 13 commits into from
Dec 7, 2020

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Nov 27, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

it replaces #205

@loic425 loic425 requested a review from a team as a code owner November 27, 2020 21:36
@loic425 loic425 closed this Nov 27, 2020
@loic425 loic425 reopened this Nov 27, 2020
@loic425
Copy link
Member Author

loic425 commented Nov 27, 2020

@pamil @lchrusciel I reworked this test app refactoring :)

Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Just one comment to make sure we don't break anything unintentionally.

Co-authored-by: Kamil Kokot <kamil@kokot.me>
@loic425
Copy link
Member Author

loic425 commented Dec 3, 2020

Cool, thanks! Just one comment to make sure we don't break anything unintentionally.

@pamil Ok now :)

@pamil pamil merged commit 62003bf into Sylius:master Dec 7, 2020
@pamil
Copy link
Contributor

pamil commented Dec 7, 2020

Thank you, Loïc! 🎉

@loic425 loic425 deleted the feature/new-test-app branch December 7, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants