Do not use deprecated Doctrine Inflector API #214
Merged
+28
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
Nov 6, 2020
| "doctrine/doctrine-bundle": "^1.12 || ^2.0", | ||
| "doctrine/event-manager": "^1.1", | ||
| "doctrine/inflector": "^1.4 || ^2.0", |
There was a problem hiding this comment.
This dependency will block newest resource bundle in the main Sylius repository: https://github.com/Sylius/Sylius/blob/master/composer.json#L195
We've conflicted with doctrine/inflector because of the fix of taxon word pluralization(from taxons to taxa). Proposed fixed may be found at: doctrine/inflector#147
There was a problem hiding this comment.
We should fix that in Sylius itself - ^1.4 is required because that's the first version that introduces forward compatibility with ^2.0.
There was a problem hiding this comment.
I'm just curious what's the best way to make that Inflector customisable - should we allow for setInflector static method on the metadata?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.