Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to overwrite a specific config file #9889

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Oct 31, 2018

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9865
License MIT

It has to be cloned to Sylius-Standard and PluginSkeleton. The behaviour stays the same as in previous versions.

@pamil pamil requested a review from a team as a code owner October 31, 2018 16:23
@pamil pamil added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Oct 31, 2018
@pamil pamil changed the title [Documentation] Make bundle templates extension part correct Allow to overwrite a specific config file Oct 31, 2018
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In perfect world we would test it somehow, to avoid regression :)

@pamil pamil merged commit 603754e into Sylius:1.3 Nov 2, 2018
@pamil pamil deleted the 1.3-kernel-container-loader branch November 2, 2018 09:46
@pamil
Copy link
Contributor Author

pamil commented Nov 2, 2018

@lchrusciel I'll create an issue to track that.

pamil added a commit to pamil/Sylius-Standard that referenced this pull request Nov 7, 2018
pamil added a commit to pamil/PluginSkeleton that referenced this pull request Nov 7, 2018
pamil added a commit to Sylius/Sylius-Standard that referenced this pull request Nov 7, 2018
This PR was merged into the 1.3 branch.

Discussion
----------



Commits
-------

00eb760 Incorporate changes from Sylius/Sylius#9889
pamil added a commit to Sylius/Sylius-Standard that referenced this pull request Nov 7, 2018
* 1.3:
  Update to Sylius v1.3.3
  Update to Sylius v1.2.10
  Apply coding standard fixes
  Incorporate changes from Sylius/Sylius#9889
pamil added a commit to Sylius/PluginSkeleton that referenced this pull request Nov 7, 2018
This PR was merged into the 1.3 branch.

Discussion
----------



Commits
-------

0f8d8af Incorporate changes from Sylius/Sylius#9889
pamil added a commit to Sylius/PluginSkeleton that referenced this pull request Nov 7, 2018
* 1.3:
  Incorporate changes from Sylius/Sylius#9889
@pamil pamil restored the 1.3-kernel-container-loader branch November 13, 2018 11:33
@pamil pamil deleted the 1.3-kernel-container-loader branch January 14, 2019 10:07
pamil added a commit that referenced this pull request Feb 5, 2019
…ain)

This PR was merged into the 1.3 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.3 or master <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | documents #9889
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.2 or 1.3 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set
-->



Commits
-------

c6f95f2 Change base dir for override config resources
windragon0910 added a commit to windragon0910/symfony_ecom_framework that referenced this pull request Oct 25, 2023
windragon0910 added a commit to windragon0910/symfony_ecom_framework that referenced this pull request Oct 25, 2023
This PR was merged into the 1.3 branch.

Discussion
----------



Commits
-------

00eb7608caa5b093c96a855884b9c0e3742c6bf1 Incorporate changes from Sylius/Sylius#9889
windragon0910 added a commit to windragon0910/symfony_ecom_framework that referenced this pull request Oct 25, 2023
* 1.3:
  Update to Sylius v1.3.3
  Update to Sylius v1.2.10
  Apply coding standard fixes
  Incorporate changes from Sylius/Sylius#9889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants