Custom homepage controller as public service #9827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the Custom homepage controller service needs to be marked as public as weel, otherwise it cannot be fetched from the container. It looks like there is a default service configuration for the controllers in config.yml which is supposed to make public all controllers in AppBundle but it doesn't resolve this issue
lchrusciel
approved these changes
Oct 15, 2018
pamil
approved these changes
Oct 16, 2018
pamil
added
Potential Bug
|
Thank you, David! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the Custom homepage controller service needs to be marked as public as well, otherwise it cannot be fetched from the container.
It looks like there is a default service configuration for the controllers in config.yml which is supposed to make public all controllers in AppBundle but it doesn't resolve this issue