[ThemeBundle] Add support for Twig namespaced paths and "templates/" top-level directory #9804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
added
Potential Bug
|
If someone could test it manually with Sylius-Standard, I'd be very grateful. :) |
|
I've just checked it on a simple case and it seems to work :) |
lchrusciel
approved these changes
Oct 10, 2018
Zales0123
approved these changes
Oct 10, 2018
Closed
|
Thank you, Kamil! 🥇 |
|
@pamil Any timeline on when this will be released? Thanks for the fix! :) |
|
Not later than tomorrow's evening. |
This was referenced Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's both a new feature (added support) and a bugfix (Symfony 4 directory structure & Twig namespaced paths aren't handled correctly now, which prevents people from using Sylius 1.3). That's why I target 1.3 with this PR.
First commit is containing all the new tests, second one provides the implementation.