Provide a BC layer for files in "app/config/" referenced by PluginSkeleton #9672
Conversation
pamil
added
Potential Bug
app/config/parameters.yml.dist
Outdated
| @@ -1,24 +0,0 @@ | |||
| # This file is auto-generated during the composer install | |||
There was a problem hiding this comment.
This file is not referenced by neither Sylius-Standard nor PluginSkeleton.
There was a problem hiding this comment.
Ah, we still need it here, it is being removed in #9665.
|
|
||
| declare(strict_types=1); | ||
|
|
||
| @trigger_error('Importing files from Sylius/Sylius\'s "app/config" directory is deprecated since Sylius 1.3.', \E_USER_DEPRECATED); |
There was a problem hiding this comment.
Deprecating YAML files is kinda weird 🎉
pamil
force-pushed
the
config-files-bc-layer
branch
from
500fd62 to
96bbbc9
Compare
|
I think this is exactly why these files should be removed from Sylius/Sylius altogether. They should only be kept for BC. But moving forward, application-related configuration must not be in Sylius/Sylius. |
|
Thanks Kamil! |
|
@teohhanhui I'm trying to solve that by making Sylius-Standard a part of Sylius/Sylius (which is subtree split back into Sylius-Standard). This way we can run tests on this repo while having one less place with configuration. |
|
Yes, make them part of the application, not part of Sylius. Sylius-Standard should be treated purely as a distribution, aka recommended scaffolding / project template. No BC guarantees. |
Files
app/config/routing.yml,app/config/routing_dev.ymlandapp/config/security.ymlare referenced in PluginSkeleton. This PR provides a backwards compatibility layer for them.