Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic names for data-* properties in sylius-lazy-choice-tree.js #9557

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Use generic names for data-* properties in sylius-lazy-choice-tree.js #9557

merged 1 commit into from
Jul 11, 2018

Conversation

teohhanhui
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes?
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

It could be used for more than taxons, so the name of the data-* properties should not include "taxon".

@teohhanhui teohhanhui force-pushed the generic-lazy-choice-tree branch from d5b70cb to f76c97c Compare July 4, 2018 17:09
@pamil pamil added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jul 4, 2018
@teohhanhui teohhanhui force-pushed the generic-lazy-choice-tree branch from f76c97c to 9c34e44 Compare July 6, 2018 16:30
@pamil
Copy link
Contributor

pamil commented Jul 10, 2018

Could you rebase the PR with the most recent master?

@teohhanhui teohhanhui force-pushed the generic-lazy-choice-tree branch from 9c34e44 to 6894bcf Compare July 10, 2018 13:12
@teohhanhui
Copy link
Contributor Author

teohhanhui commented Jul 10, 2018 •
edited
Loading

Rebased.

@pamil pamil merged commit fc17e78 into Sylius:master Jul 11, 2018
@pamil
Copy link
Contributor

pamil commented Jul 11, 2018

Thank you, Teoh! 🎉

@teohhanhui teohhanhui deleted the generic-lazy-choice-tree branch July 11, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teohhanhui @pamil @Zales0123