[Addressing] Fix default validation groups of AddressType #9436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
approved these changes
May 31, 2018
pamil
added
the
Potential Bug
|
Rebased to 1.0 in order to include that in the last bugfix release for that branch, good to merge as soon as tests pass. |
|
Thank you, Victor! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the
$options['shippable']is true, 'shippable' validation group is added persistently to the form type default validation groups and used subsequently despite the$options['shippable']value.In case of
\Sylius\Bundle\CoreBundle\Form\Type\Checkout\AddressTypewhich has 2 fields of that type, both of them will have validation groups includingshippable, even if the 2nd one (billingAddress) does not have'shippable' => trueoption.Moreover, in case of more than 1 field with
'shippable' => true, validation groups will contain an entry ofshippablegroup per field.