Fix exception controller config #9344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2018
|
ping @pamil |
| @@ -51,7 +51,7 @@ swiftmailer: | |||
| password: "%mailer_password%" | |||
|
|
|||
| fos_rest: | |||
| exception: ~ | |||
| exception: true | |||
There was a problem hiding this comment.
I didnt need this change in order to make exceptions work. Is it used on the Api?
There was a problem hiding this comment.
Yes, this is for the API.
| @@ -9,5 +9,9 @@ _profiler: | |||
| resource: "@WebProfilerBundle/Resources/config/routing/profiler.xml" | |||
| prefix: /_profiler | |||
|
|
|||
| _errors: | |||
| resource: '@TwigBundle/Resources/config/routing/errors.xml' | |||
There was a problem hiding this comment.
using “ instead of ‘ would be better, to maintain consistency on config files
There was a problem hiding this comment.
This is copied straight from Symfony Standard. I suggest not to change it for now.
pamil
approved these changes
Apr 25, 2018
|
Thank you, Teoh, and sorry for the delay! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception controller was configured incorrectly. You can easily tell by going to
/app_dev.php/_error/404.html