[Adjustment] Inject adjustment types that shall be cleared #9308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
the
Enhancement
pamil
approved these changes
Apr 6, 2018
|
Can't see any BC breaks, where are they? |
|
My bad, they've just vanished magically 😄 ⭐️ |
pamil
suggested changes
Apr 6, 2018
|
IIRC we can get this info by calling We also need to trigger user deprecation error there, just as Symfony does it: |
pamil
reviewed
Apr 6, 2018
| @@ -26,6 +26,18 @@ | |||
|
|
|||
| public function __construct(array $adjustmentsToRemove = []) | |||
| { | |||
| if (0 === func_num_args()) { | |||
| @trigger_error('Adjustment types should be passed explicitly', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
We also might want to mention that not passing them is deprecated since 1.2 and will be prohibited by 2.0
Zales0123
force-pushed
the
inject-adjustments-to-clear
branch
from
dec7ed2 to
e7f020e
Compare
pamil
approved these changes
Apr 10, 2018
|
Yay, first deprecation in Sylius, thank you Mateusz! 🥇 |
|
I'm very happy I could provide that, I hope we will be able to have as many deprecations as possible xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact, that cleared adjustments types has been set as static array, after adding new adjustment type (that is also processed during checkout), it was necessary to implement whole new class (with very similar/the same implementation, but different static array) and override the service definition. With this change, only definition overriding is needed.