Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Balrog of Morgoth name #9269

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

It was quite frustrating to see such a big disrespect for this awesome creature :/
http://lotr.wikia.com/wiki/Balrog
To be precisely, we should refer to a specific Balrog's name (Durin's Bane in this case), but it can be a little bit confusing, so it's good as it is right now :)

zrzut ekranu 2018-03-16 o 11 51 45

@Zales0123 Zales0123 added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. DX Issues and PRs aimed at improving Developer eXperience. labels Mar 16, 2018
@Zales0123 Zales0123 requested a review from CoderMaggie as a code owner March 16, 2018 10:52
@pamil pamil merged commit b25d289 into Sylius:1.0 Mar 16, 2018
@pamil
Copy link
Contributor

pamil commented Mar 16, 2018

Could you wait two weeks for a next bugfix release or should I tag another one today? :)

@Zales0123
Copy link
Member Author

I think I can wait - what are 2 weeks comparing to the infinity of the universe? 🐃

@Zales0123 Zales0123 deleted the fix-wrong-balrog-of-morgoth-name branch March 29, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants