Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][CookBook] Specific SyliusBundles extension #9264

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

Zales0123
Copy link
Member

Q A
Doc fix? no
New docs? yes
Related tickets
License MIT

Rebased and slightly improved #8517, thank you @Adraesh for your tremendous work!

@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Mar 15, 2018
@Zales0123 Zales0123 requested a review from CoderMaggie March 15, 2018 08:59
@Zales0123 Zales0123 changed the title Docs/extending bundle other em [Documentation][CookBook] Specific SyliusBundles extension Mar 15, 2018
@Zales0123
Copy link
Member Author

ping @CoderMaggie

}

/**
* Set user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all these comments? Doc will be more compact without it

@lchrusciel lchrusciel merged commit 5c14c09 into Sylius:1.0 Mar 23, 2018
@lchrusciel
Copy link
Member

Thanks Mateusz! 🐋

@lchrusciel
Copy link
Member

Forgive me my ignorance, and Thomas as well! 🐋 ☮️

@Zales0123 Zales0123 deleted the docs/extending-bundle-other-em branch March 29, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants