Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AttributeBundle] Fixing composer.json for ramsey/uuid #9233

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

David-Crty
Copy link
Contributor

Q A
Branch? 1.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

We use AttributeBundle as a standalone and since this commit 59b1375 we have issue about a missing lib ramsey/uuid.
I just added in the composer.json of the AttributeBundle

The lib is used in src/Sylius/Bundle/AttributeBundle/Form/Type/AttributeType/Configuration/SelectAttributeChoicesCollectionType.php

Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mentioned commit was merged into 1.0 branch so this fix should be merged into that branch as well. I'll try to rebase it so that you don't have to :)

@pamil pamil added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Mar 8, 2018
@pamil pamil added this to the 1.0 milestone Mar 8, 2018
@pamil pamil changed the base branch from 1.1 to 1.0 March 8, 2018 13:42
We use AttributeBundle as a standalone and since this commit Sylius@59b1375 we have issue about a missing lib ramsey/uuid.

The lib is used in src/Sylius/Bundle/AttributeBundle/Form/Type/AttributeType/Configuration/SelectAttributeChoicesCollectionType.php
@pamil pamil merged commit 172d919 into Sylius:1.0 Mar 8, 2018
@pamil
Copy link
Contributor

pamil commented Mar 8, 2018

Thanks David! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants