Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required parameters to the Route generation #9166

Closed
wants to merge 1 commit into from

Conversation

GitProdEnv
Copy link
Contributor

According to the documentation we link to a specific supplier contact. In the custom action {% set path = ... %} the additional id parameter is missing.
An exception has been thrown during the rendering of a template ("Some mandatory parameters are missing ("id") to generate a URL for route "app_admin_supplier_show".").

Q A
Branch? 1.0, 1.1 or master
Bug fix? no/yes
New feature? no/yes
BC breaks? no/yes
Deprecations? no/yes
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

According to the documentation we link to a specific supplier contact. In the custom action {% set path = ... %} the additional id parameter is missing. 
<cite>An exception has been thrown during the rendering of a template ("Some mandatory parameters are missing ("id") to generate a URL for route "app_admin_supplier_show".").</cite>
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 9, 2018
@pamil pamil added this to the 1.0 milestone Feb 9, 2018
@pamil
Copy link
Contributor

pamil commented Feb 9, 2018

Thanks @GitProdEnv! I've merged your PR to 1.0 branch as it is a bugfix (711081e).

@pamil pamil closed this Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants