Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax error fix in doc code snippet #8998

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Syntax error fix in doc code snippet #8998

merged 1 commit into from
Dec 4, 2017

Conversation

t-geindre
Copy link
Contributor

@t-geindre t-geindre commented Nov 30, 2017 •
edited by lchrusciel
Loading

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

Just a quick fix on filters documentation.

@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Dec 1, 2017
lchrusciel
lchrusciel previously requested changes Dec 1, 2017
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it should be merged to branch 1.0

@lchrusciel lchrusciel changed the base branch from master to 1.0 December 1, 2017 07:17
@CoderMaggie
Copy link
Member

Hi! Great to see your first contribution to Sylius! 🎊
As @lchrusciel has pointed out this PR should go to the 1.0 branch. Can you please rebase your branch with 1.0 and repush @t-geindre ? 🙏

@t-geindre
Copy link
Contributor Author

@CoderMaggie Sorry for the mistake. My branch has been rebased.

@pamil pamil added this to the 1.0 milestone Dec 1, 2017
@pamil pamil dismissed lchrusciel’s stale review December 1, 2017 09:33

Not longer relevant

@pamil pamil merged commit 9e1dc75 into Sylius:1.0 Dec 4, 2017
@pamil
Copy link
Contributor

pamil commented Dec 4, 2017

Failing build was not related to the changes, thanks @t-geindre! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@t-geindre @CoderMaggie @pamil @Zales0123 @lchrusciel