Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong use statement for ProductInterface #8937

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Fix wrong use statement for ProductInterface #8937

merged 1 commit into from
Nov 7, 2017

Conversation

stefandoorn
Copy link
Contributor

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

After the question at https://stackoverflow.com/questions/47135122/error-following-sylius-customizing-factories-guide-examples, it seems the use statement shown in the example is wrong when checking it agains the 1.0 code base.

GSadee
GSadee reviewed Nov 7, 2017
View reviewed changes
docs/customization/factory.rst Outdated
@@ -41,7 +41,7 @@ Take its interface (``Sylius\Component\Product\Factory\ProductFactoryInterface``

namespace AppBundle\Factory;

use Sylius\Component\Core\Model\ProductInterface;
use Sylius\Component\Product\Model\ProductInterface;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicated ;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ;-)

@CoderMaggie CoderMaggie added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Nov 7, 2017
@CoderMaggie CoderMaggie added this to the 1.0 milestone Nov 7, 2017
@stefandoorn stefandoorn force-pushed the docs-factory-product-interface branch from 1f5159e to 6283e4b Compare November 7, 2017 07:11
@lchrusciel lchrusciel merged commit a0f0aa3 into Sylius:1.0 Nov 7, 2017
@lchrusciel
Copy link
Member

lchrusciel commented Nov 7, 2017 •
edited
Loading

Thanks Stefan! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@CoderMaggie CoderMaggie CoderMaggie approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefandoorn @lchrusciel @GSadee @CoderMaggie