[Travis] Update Yarn to stable 1.2.1, use Node v6 #8915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
reviewed
Nov 6, 2017
| @@ -14,15 +14,15 @@ matrix: | |||
| php: 7.1 | |||
| env: | |||
| - SYLIUS_SUITE="application" | |||
| - TRAVIS_NODE_VERSION="7.5" | |||
| - TRAVIS_NODE_VERSION="6.11" | |||
There was a problem hiding this comment.
Let's use 8.9 version instead, it's the latest supported one.
There was a problem hiding this comment.
Aaah okay, missed the description.
| @@ -15,4 +15,4 @@ run_command "rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/ | |||
| run_command "sudo apt-key adv --fetch-keys http://dl.yarnpkg.com/debian/pubkey.gpg" | |||
| run_command "echo \"deb http://dl.yarnpkg.com/debian/ stable main\" | sudo tee /etc/apt/sources.list.d/yarn.list" | |||
| run_command "sudo apt-get update -qq" | |||
| run_command "sudo apt-get install -y -qq yarn=0.21.3-1" | |||
| run_command "sudo apt-get install -y -qq yarn=1.2.1-1" | |||
There was a problem hiding this comment.
Hah, of course they release 1.3 two days after I open this PR 😄 I'll save it for another time if you don't mind, at least we're stable now 🤞
There was a problem hiding this comment.
Yeah, we can wait for Trusty setup to make both Node 8.x and Yarn 1.3.x
pamil
approved these changes
Nov 6, 2017
|
Thanks @venyii! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also uses LTS Node v6 since v7 is not officially supported:
To use Node v8, we'd need either Trusty (which causes some problems as you know) or upgrade gcc ourselves, but I'd just wait and see if Trusty works in the near future.