Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backwards compatibility promise #8901

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Backwards compatibility promise #8901

merged 1 commit into from
Oct 27, 2017

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Oct 25, 2017

Q A
Branch? 1.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets related to #8748
License MIT

@pamil pamil added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Oct 25, 2017
@pamil pamil added this to the 1.0 milestone Oct 25, 2017
@pamil pamil self-assigned this Oct 25, 2017
GSadee
GSadee reviewed Oct 25, 2017
View reviewed changes
docs/contributing/code/bc.rst
Code covered
------------

This BC promise applies to all of Sylius' PHP code except for:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe js files should be added to this list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS files aren't PHP code 🎉

@GSadee GSadee mentioned this pull request Oct 27, 2017
Merged
@pjedrzejewski pjedrzejewski merged commit ac34193 into Sylius:1.0 Oct 27, 2017
@pjedrzejewski
Copy link
Member

Thank you Kamil, nice work! 👍

@pamil pamil deleted the 1.0-bc-promise branch October 27, 2017 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@GSadee GSadee GSadee approved these changes

Assignees

@pamil pamil

Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pamil @pjedrzejewski @GSadee @Zales0123 @CoderMaggie