Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminApi] Fix nullable ClientInterface return type in admin api #8869

Merged
merged 1 commit into from
Oct 18, 2017
Merged

[AdminApi] Fix nullable ClientInterface return type in admin api #8869

merged 1 commit into from
Oct 18, 2017

Conversation

vntw
Copy link
Contributor

@vntw vntw commented Oct 17, 2017

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #8673
License MIT

The underlying findOneBy may return null, the docblock seems to be
wrong. The null value will be handled correctly in the AuthorizeController.

@vntw
Fix nullable ClientInterface return type in admin api
a117582 
The underlying `findOneBy` may return null, the docblock seems to be
wrong.
@GSadee GSadee added this to the 1.0 milestone Oct 18, 2017
@GSadee GSadee added the API APIs related issues and PRs. label Oct 18, 2017
@GSadee GSadee requested a review from lchrusciel October 18, 2017 07:12
@GSadee GSadee merged commit 32d1391 into Sylius:1.0 Oct 18, 2017
@GSadee
Copy link
Member

GSadee commented Oct 18, 2017

Thanks @venyii!

@vntw vntw deleted the fix-nullable-client-admin-api branch October 18, 2017 08:21
@pamil pamil mentioned this pull request Oct 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@pamil pamil pamil approved these changes

@lchrusciel lchrusciel Awaiting requested review from lchrusciel

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vntw @GSadee @pamil @Zales0123