Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Add typehints to customization guide #8844

Merged
merged 1 commit into from
Oct 16, 2017
Merged

[Documentation] Add typehints to customization guide #8844

merged 1 commit into from
Oct 16, 2017

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Oct 15, 2017 •
edited
Loading

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@GSadee GSadee added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Oct 15, 2017
@GSadee GSadee added this to the 1.0 milestone Oct 15, 2017
@GSadee GSadee requested a review from CoderMaggie October 15, 2017 10:32
@GSadee GSadee force-pushed the docs-customization-strict-types branch from 6f8f253 to 64c3def Compare October 15, 2017 11:53
pamil
pamil suggested changes Oct 16, 2017
View reviewed changes
docs/customization/model.rst Outdated
*/
public function getDeliveryConditions()
public function setDeliveryConditions(?string $deliveryConditions = null): void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value does not make too much sense for a setter :)

@GSadee GSadee force-pushed the docs-customization-strict-types branch from 64c3def to c78ab56 Compare October 16, 2017 08:50
@Zales0123 Zales0123 merged commit 9a4223e into Sylius:1.0 Oct 16, 2017
@Zales0123
Copy link
Member

Thank you Grześ!

@GSadee GSadee deleted the docs-customization-strict-types branch October 16, 2017 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GSadee @Zales0123 @pamil @CoderMaggie