Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run security:check to actively check issues in Composer dependencies #8770

Merged
merged 2 commits into from
Oct 10, 2017

Conversation

stefandoorn
Copy link
Contributor

Q A
Branch? 1.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

Not sure 1.0 is good here, but let's first see if it works on Travis. Next to validating Composer, Yarn, etc, it might also be good to check dependencies for known security issues. Currently there is nothing, but it's good to keep it automated I think.

@stefandoorn
Copy link
Contributor Author

Small issue on Travis: https://github.com/sensiolabs/security-checker/issues/75. Will try workaround.

@Zales0123 Zales0123 requested a review from pamil October 10, 2017 06:26
@pamil pamil added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Oct 10, 2017
@pamil pamil added this to the 1.0 milestone Oct 10, 2017
@pamil pamil merged commit af758d6 into Sylius:1.0 Oct 10, 2017
@pamil
Copy link
Contributor

pamil commented Oct 10, 2017

Thanks Stefan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants