[Documentation] Explain how to contribute using vagrant #8715

loic425 · 2017-09-21T13:03:13Z

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Related tickets
License	MIT

GSadee · 2017-09-21T13:51:02Z

docs/contributing/index.rst

+
+    This article assumes you're familiar with `Composer`_, a dependency manager
+    for PHP. It also assumes you have `Composer installed globally`_.
+    Basic knowledgle about `Vagrant <https://www.vagrantup.com/about.html>`_ is also required,


knowledgle -> knowledge

@GSadee Thank you, i've also updated on this page: http://docs.sylius.org/en/latest/book/installation/vagrant_installation.html.

lchrusciel · 2017-09-21T18:20:27Z

docs/contributing/index.rst


 .. _Gulp: http://gulpjs.com/
 .. _Node.js: https://nodejs.org/en/download/

+
+How to contribute using Sylius Vagrant


I think it would be much better to keep vagrant description in repo readme and here just create a link to the repo.

How to contribute using Sylius Vagrant If you would like to contribute to the repo without worrying about environment, you can follow this guide to setup you vagrant machine

lchrusciel · 2017-09-22T09:33:14Z

docs/contributing/index.rst

+--------------------------------------
+
+If you would like to contribute to the repo without worrying about environment, you can follow `this guide <https://github.com/Sylius/Vagrant/blob/master/README.md#configure-vagrant-to-contribute-on-sylius-core>`_ to setup you vagrant machine
+


redundant blank line

lchrusciel · 2017-09-22T09:37:02Z

@loic425 For me it is ready to merge, but unfortunately, the build is failing. We need to wait for #8722 to be merged to branch 1.0 and rebase it then. It is not something related to your changes, I suppose.

lchrusciel · 2017-09-22T09:40:56Z

@loic425 my bad. It will be enough if you just rebase to the newest 1.0 and it is ready to merge

lchrusciel · 2017-09-22T09:42:27Z

Sorry, my bad. #8722 has been merged to 1.0. So all you need to do is to rebase 1.0 with the upstream.

CoderMaggie · 2017-09-22T09:43:07Z

docs/contributing/index.rst

+How to contribute using Sylius Vagrant
+--------------------------------------
+
+If you would like to contribute to the repo without worrying about environment, you can follow `this guide <https://github.com/Sylius/Vagrant/blob/master/README.md#configure-vagrant-to-contribute-on-sylius-core>`_ to setup you vagrant machine


you -> your
And a missing . at the end of sentence.

loic425 · 2017-09-22T16:39:34Z

Ok cool I will fix them all on monday and make a rebase.

loic425 · 2017-09-26T14:30:39Z

@lchrusciel @CoderMaggie I've tried to rebase and it dit not work. I've tried another method (same i've used with lcruschiel on another PR).

git checkout -b backup/docs/contributing-with-vagrant
git branch -d docs/contributing-with-vagrant
git checkout 1.0
git pull upstream 1.0
git checkout -b docs/contributing-with-vagrant
git cherry-pick 7c26b6cd6ffab2ef5b63336f778d271c08d78227
git cherry-pick c0bcdf3760b2de78f1730c51b6d056949a2159b8
git cherry-pick 3fc6495b35ff3f2123411339c10271d6ac15151a
git cherry-pick ca54173832807bc3222415f6c181075e5e661b82
git push docs/contributing-with-vagrant --force

And the build failed: https://travis-ci.org/Sylius/Sylius/jobs/279942407

Zales0123 · 2017-09-27T06:38:43Z

@loic425 rebase seems to work (at least commits are fine), the failing build is due to some docs errors... I don't is it something new, or it was fixed before, we need @CoderMaggie for that 😄

loic425 · 2017-09-27T07:50:03Z

@Zales0123 Ok thanks. @CoderMaggie Let me know if I have to change something on this Pull-request.

pamil · 2017-09-27T08:26:29Z

Cleared the cache for failing build and rerun it, let's see if the error is still there :)

loic425 · 2017-09-27T09:28:47Z

@pamil can I clear the cache for failing build or is this something one of your team can do ?

pamil · 2017-09-27T09:35:59Z

@loic425 unfortunately Travis allows for that only for those with push access to the repository

loic425 · 2017-10-04T08:27:58Z

@pamil @pjedrzejewski Is it possible to clear travis cache in order to conclude this pull-request ? :)

lchrusciel · 2017-10-09T07:31:21Z

@loic425 the problems seems not to be with cache itself, rather some internal Sylius error. As the main build seems to be green, can you rebase it to the newest 1.0 one more time?

loic425 · 2017-10-10T19:41:24Z

@pamil I've seen you tried to rebase it. This is weird...

CoderMaggie · 2017-10-12T08:14:01Z

@loic425 the failing build is fixed now in #8825
Can you make a rebase to 1.0 one last time? :)

loic425 · 2017-10-12T08:17:33Z

@CoderMaggie Ok, I will make a rebase today.

loic425 · 2017-10-13T08:54:21Z

@CoderMaggie docs build still fail on travis :(

I used a cherry pick method to apply the commits.

CoderMaggie · 2017-10-15T08:20:18Z

docs/contributing/index.rst

+How to contribute using Sylius Vagrant
+--------------------------------------
+
+If you would like to contribute to the repo without worrying about environment, you can follow `this guide <https://github.com/Sylius/Vagrant/blob/master/README.md#configure-vagrant-to-contribute-on-sylius-core>`_ to setup your vagrant machine.


This reference https://github.com/Sylius/Vagrant/blob/master/README.md#configure-vagrant-to-contribute-on-sylius-core is failing the build @loic425 :(

Can we do it this way?:

If you would like to contribute to the repo without worrying about environment, you can follow `the "Configure Vagrant to contribute on Sylius Core" section here <https://github.com/Sylius/Vagrant/blob/master/README.md>`_ to setup your vagrant machine.

@CoderMaggie cool you found why this build fail. I'm gonna do that on monday.

loic425 · 2017-10-16T14:33:45Z

@CoderMaggie Build is now ok :)

CoderMaggie · 2017-10-17T06:28:12Z

Thanks @loic425 :)

lchrusciel · 2017-10-17T08:36:15Z

🎉

loic425 · 2017-10-17T09:39:50Z

@CoderMaggie @lchrusciel after a lot of rebases and such annoying steps, it's finally merged :)

lchrusciel · 2017-10-17T10:20:38Z

I hope it won't stop you from contributing to us :D

loic425 · 2017-10-17T12:21:24Z

@lchrusciel lol, of course not:)

pamil added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Sep 21, 2017

pamil added this to the 1.0 milestone Sep 21, 2017

pamil requested review from CoderMaggie and lchrusciel September 21, 2017 13:06

GSadee reviewed Sep 21, 2017

View reviewed changes

lchrusciel suggested changes Sep 21, 2017

View reviewed changes

lchrusciel approved these changes Sep 22, 2017

View reviewed changes

CoderMaggie approved these changes Sep 22, 2017

View reviewed changes

loic425 force-pushed the docs/contributing-with-vagrant branch 2 times, most recently from ca54173 to ac3c1b8 Compare September 26, 2017 12:38

pamil mentioned this pull request Oct 10, 2017

[Documentation] Explain how to contribute using vagrant #8806

Closed

loicmobizel added 4 commits October 13, 2017 10:31

Explain how to contribute using vagrant

5202690

Fix typo on documentation

2bd2537

replace sylius vagrant guide with a link to the vagrant readme file

02848d8

few changes after review

4ba555b

loic425 force-pushed the docs/contributing-with-vagrant branch from ac3c1b8 to 4ba555b Compare October 13, 2017 08:33

CoderMaggie reviewed Oct 15, 2017

View reviewed changes

fix link to Configure Vagrant to contribute on Sylius Core section

632521c

CoderMaggie approved these changes Oct 17, 2017

View reviewed changes

CoderMaggie merged commit ade5aec into Sylius:1.0 Oct 17, 2017

loic425 deleted the docs/contributing-with-vagrant branch February 26, 2018 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Documentation] Explain how to contribute using vagrant #8715

[Documentation] Explain how to contribute using vagrant #8715

loic425 commented Sep 21, 2017

GSadee Sep 21, 2017

loic425 Sep 21, 2017 •

edited

Loading

lchrusciel Sep 21, 2017

lchrusciel Sep 22, 2017

lchrusciel commented Sep 22, 2017

lchrusciel commented Sep 22, 2017

lchrusciel commented Sep 22, 2017

CoderMaggie Sep 22, 2017

loic425 commented Sep 22, 2017 •

edited

Loading

loic425 commented Sep 26, 2017

Zales0123 commented Sep 27, 2017

loic425 commented Sep 27, 2017

pamil commented Sep 27, 2017

loic425 commented Sep 27, 2017

pamil commented Sep 27, 2017

loic425 commented Oct 4, 2017

lchrusciel commented Oct 9, 2017

loic425 commented Oct 10, 2017

CoderMaggie commented Oct 12, 2017

loic425 commented Oct 12, 2017

loic425 commented Oct 13, 2017 •

edited

Loading

CoderMaggie Oct 15, 2017

loic425 Oct 15, 2017

loic425 commented Oct 16, 2017

CoderMaggie commented Oct 17, 2017

lchrusciel commented Oct 17, 2017

loic425 commented Oct 17, 2017

lchrusciel commented Oct 17, 2017

loic425 commented Oct 17, 2017

		--------------------------------------

		If you would like to contribute to the repo without worrying about environment, you can follow `this guide <https://github.com/Sylius/Vagrant/blob/master/README.md#configure-vagrant-to-contribute-on-sylius-core>`_ to setup you vagrant machine

[Documentation] Explain how to contribute using vagrant #8715

[Documentation] Explain how to contribute using vagrant #8715

Conversation

loic425 commented Sep 21, 2017

GSadee Sep 21, 2017

Choose a reason for hiding this comment

loic425 Sep 21, 2017 • edited Loading

Choose a reason for hiding this comment

lchrusciel Sep 21, 2017

Choose a reason for hiding this comment

lchrusciel Sep 22, 2017

Choose a reason for hiding this comment

lchrusciel commented Sep 22, 2017

lchrusciel commented Sep 22, 2017

lchrusciel commented Sep 22, 2017

CoderMaggie Sep 22, 2017

Choose a reason for hiding this comment

loic425 commented Sep 22, 2017 • edited Loading

loic425 commented Sep 26, 2017

Zales0123 commented Sep 27, 2017

loic425 commented Sep 27, 2017

pamil commented Sep 27, 2017

loic425 commented Sep 27, 2017

pamil commented Sep 27, 2017

loic425 commented Oct 4, 2017

lchrusciel commented Oct 9, 2017

loic425 commented Oct 10, 2017

CoderMaggie commented Oct 12, 2017

loic425 commented Oct 12, 2017

loic425 commented Oct 13, 2017 • edited Loading

CoderMaggie Oct 15, 2017

Choose a reason for hiding this comment

loic425 Oct 15, 2017

Choose a reason for hiding this comment

loic425 commented Oct 16, 2017

CoderMaggie commented Oct 17, 2017

lchrusciel commented Oct 17, 2017

loic425 commented Oct 17, 2017

lchrusciel commented Oct 17, 2017

loic425 commented Oct 17, 2017

loic425 Sep 21, 2017 •

edited

Loading

loic425 commented Sep 22, 2017 •

edited

Loading

loic425 commented Oct 13, 2017 •

edited

Loading