add sylius version to the footer in admin #8680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
BC Break
lchrusciel
reviewed
Sep 18, 2017
|
let's take them one by one:
|
|
I totally agree with the second point. I just don't think that we need this |
Zales0123
approved these changes
Sep 19, 2017
gabiudrescu
force-pushed
the
fix_8679
branch
from
ea5db83 to
fee8bdc
Compare
|
OK, I have reverted that change introducing the constant. |
lchrusciel
approved these changes
Sep 19, 2017
|
Couldn't spot any BC break here, is it still there? /cc @Zales0123 |
lchrusciel
approved these changes
Oct 11, 2017
|
For me it is good to go |
Zales0123
approved these changes
Oct 11, 2017
pamil
suggested changes
Oct 11, 2017
app/config/config.yml
Outdated
| @@ -61,3 +61,8 @@ fos_rest: | |||
| rules: | |||
| - { path: '^/api/.*', priorities: ['json', 'xml'], fallback_format: json, prefer_extension: true } | |||
| - { path: '^/', stop: true } | |||
|
|
|||
| twig: | |||
There was a problem hiding this comment.
Can we add it to @CoreBundle/Resources/config/app/config.yml instead? Btw. we can name it sylius_meta.
lchrusciel
approved these changes
Oct 16, 2017
|
Thanks Gabi! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
add sylius version to the footer in admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the version was missing from admin due to a bug in a twig file - the footer block in admin got renamed post_content at some point in history.
On top of fixing this bug, I added a new constant in the kernel class, APP_NAME with the default value being "Sylius". In case at a later point someone decides to craft a forked version of Sylius called "Supercharged Sylius" and it needs to brag about the name. Before hand, Sylius was hardcoded in the twig template.
I have declared both Sylius\Bundle\CoreBundle\Application\Kernel::VERSION and Sylius\Bundle\CoreBundle\Application\Kernel::APP_NAME as twig global variables and used them to be in the twig layout template for admin.
I consider this useful when debugging a Sylius application over the phone with a non-technical person. First question I would ask is: what version of Sylius do you run?
Also, I find it a good reason to brag about: look, I'm running Sylius 1.0.0!