Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Rename and deprecate route parameters #17241

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Oct 15, 2024

Q A
Branch? 1.14
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Related tickets
License MIT

@GSadee GSadee added Maintenance CI configurations, READMEs, releases, etc. API APIs related issues and PRs. labels Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@GSadee GSadee marked this pull request as ready for review October 15, 2024 12:17
@GSadee GSadee requested review from a team as code owners October 15, 2024 12:17
Wojdylak
Wojdylak previously approved these changes Oct 15, 2024
@NoResponseMate NoResponseMate merged commit d47bd90 into Sylius:1.14 Oct 17, 2024
30 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @GSadee!

@GSadee GSadee deleted the api-rename-new-api-parameters branch October 17, 2024 10:20
NoResponseMate added a commit that referenced this pull request Oct 18, 2024
This PR was merged into the 2.0 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 2.0
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no<!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | continuation of #17241
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------
  [API] Rename route parameters
  [API] Remove UPGRADE-API-1.14 file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants