Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GA] Enable non-ui e2e steps + fixes #16932

Merged

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? bootstrap-shop
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

@NoResponseMate NoResponseMate added the CI Issues and PRs related to automated testing label Sep 13, 2024
@NoResponseMate NoResponseMate requested review from a team as code owners September 13, 2024 06:28
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@NoResponseMate NoResponseMate marked this pull request as draft September 13, 2024 12:34
@NoResponseMate NoResponseMate force-pushed the SYL-3903/prepare-bs-for-merge branch from f6dea89 to 074d016 Compare September 13, 2024 14:04
@NoResponseMate NoResponseMate changed the title [GA] Enable non-ui e2e steps [GA] Enable non-ui e2e steps + fixes Sep 13, 2024
@NoResponseMate NoResponseMate marked this pull request as ready for review September 13, 2024 14:43
@NoResponseMate NoResponseMate force-pushed the SYL-3903/prepare-bs-for-merge branch from 074d016 to 7bc3e12 Compare September 16, 2024 09:44
public function iShouldNotBeAbleToSpecifyProvinceNameManuallyForBillingAddress(): void
{
$this->assertProvinceMessage('billingAddress');
$response = $this->client->getLastResponse();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not to be needed

Suggested change
$response = $this->client->getLastResponse();

@GSadee GSadee merged commit b832f7f into Sylius:bootstrap-shop Sep 16, 2024
20 checks passed
@NoResponseMate NoResponseMate deleted the SYL-3903/prepare-bs-for-merge branch September 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues and PRs related to automated testing Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants