[Shop] Currency switcher #16861
Merged
[Shop] Currency switcher #16861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # features/shop/currency/handling_different_currencies_on_multiple_channels.feature # features/shop/currency/switching_current_currency.feature
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
reviewed
Sep 5, 2024
src/Sylius/Bundle/ShopBundle/Twig/Component/Common/CurrencySwitcherComponent.php
Outdated
Show resolved
Hide resolved
Rafikooo
approved these changes
Sep 5, 2024
Comment on lines
+36
to
+43
| #[ExposeInTemplate] | ||
| public ?string $price = null; | ||
|
|
||
| #[ExposeInTemplate(name: 'original_price')] | ||
| public ?string $originalPrice = null; | ||
|
|
||
| #[ExposeInTemplate(name: 'has_discount')] | ||
| public bool $hasDiscount = false; |
There was a problem hiding this comment.
Why is there a missing name declaration here? Are the following defined to enforce snake case?
Suggested change
| #[ExposeInTemplate] | |
| public ?string $price = null; | |
| #[ExposeInTemplate(name: 'original_price')] | |
| public ?string $originalPrice = null; | |
| #[ExposeInTemplate(name: 'has_discount')] | |
| public bool $hasDiscount = false; | |
| #[ExposeInTemplate(name: 'price')] | |
| public ?string $price = null; | |
| #[ExposeInTemplate(name: 'original_price')] | |
| public ?string $originalPrice = null; | |
| ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made currency switcher twig component, enabled currency scenarios. Refactored CardComponent - removed duplicated PriceComponents