[Shop][Product] Adding products to cart #16774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Wojdylak
commented
Aug 26, 2024
Wojdylak
commented
| Q | A |
|---|---|
| Branch? | bootstrap-shop |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | n/a |
| License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
force-pushed
the
SYL-3732-adding-products-to-cart
branch
from
e6e86bc to
55c5414
Compare
mpysiak
reviewed
Aug 28, 2024
| use Symfony\UX\LiveComponent\Attribute\LiveArg; | ||
| use Symfony\UX\LiveComponent\Attribute\LiveListener; | ||
| use Symfony\UX\LiveComponent\Attribute\LiveProp; | ||
| use Symfony\UX\LiveComponent\DefaultActionTrait; | ||
| use Symfony\UX\TwigComponent\Attribute\PostMount; | ||
|
|
||
| #[AsLiveComponent] |
mpysiak
approved these changes
Aug 28, 2024
TheMilek
approved these changes
Aug 28, 2024
| { | ||
| public function __construct(private OrderModifierInterface $orderModifier) | ||
| { | ||
| } | ||
|
|
||
| public function removeOrderItem(GenericEvent $event): void | ||
| public function removeFromOrder(GenericEvent $event): void |
There was a problem hiding this comment.
Suggested change
| public function removeFromOrder(GenericEvent $event): void | |
| public function removeItemFromOrder(GenericEvent $event): void |
🤔
| @@ -1,5 +1,5 @@ | |||
| {% set item = hookable_metadata.context.item %} | |||
|
|
|||
| <td {{ sylius_test_html_attribute('cart-item-product' ) }}> | |||
| {% include '@SyliusShop/shared/product/info.html.twig' with {'variant': item.variant} %} | |||
| {{ component('sylius_shop:order_item:product_info', { item: item }) }} | |||
There was a problem hiding this comment.
can we declare this component in hooks?
GSadee
approved these changes
Aug 28, 2024
Comment on lines
+109
to
+111
| FlashBagProvider | ||
| ::getFlashBag($this->requestStack) | ||
| ->add('success', 'sylius.cart.add_item'); |
There was a problem hiding this comment.
Suggested change
| FlashBagProvider | |
| ::getFlashBag($this->requestStack) | |
| ->add('success', 'sylius.cart.add_item'); | |
| FlashBagProvider::getFlashBag($this->requestStack) | |
| ->add('success', 'sylius.cart.add_item') | |
| ; |
or even
Suggested change
| FlashBagProvider | |
| ::getFlashBag($this->requestStack) | |
| ->add('success', 'sylius.cart.add_item'); | |
| FlashBagProvider::getFlashBag($this->requestStack)->add('success', 'sylius.cart.add_item'); |
| @@ -44,6 +48,7 @@ public function createForProduct(ProductInterface $product): OrderItemInterface | |||
| $variant = $this->variantResolver->getVariant($product); | |||
| Assert::nullOrIsInstanceOf($variant, ProductVariantInterface::class); | |||
| $cartItem->setVariant($variant); | |||
| $this->orderItemQuantityModifier->modify($cartItem, 1); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.