[Shop] Locale switcher #16770
Merged
[Shop] Locale switcher #16770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mpysiak
commented
Aug 23, 2024
mpysiak
commented
| Q | A |
|---|---|
| Branch? | bootstrap-shop |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | n/a |
| License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
GSadee
approved these changes
Aug 23, 2024
NoResponseMate
approved these changes
Aug 23, 2024
Comment on lines
+168
to
+241
| key="sylius_shop:common:locale_switcher" | ||
| template="@SyliusShop/shared/layout/base/header/top_bar/locale_switch.html.twig" |
There was a problem hiding this comment.
The only questionable thing for me is either the name of the component and/or the template placement, but we can think about it at a later time when upgrading the currency switcher etc.
mpysiak
force-pushed
the
SYL-3807-locale-switcher
branch
from
7291cbb to
1459d6d
Compare
Wojdylak
reviewed
Aug 26, 2024
src/Sylius/Bundle/ShopBundle/Twig/Component/Common/LocaleSwitcher.php
Outdated
Show resolved
Hide resolved
mpysiak
force-pushed
the
SYL-3807-locale-switcher
branch
from
1459d6d to
e3b0bc3
Compare
GSadee
approved these changes
Aug 26, 2024
# Conflicts: # src/Sylius/Bundle/ShopBundle/Resources/config/services/twig/component.xml
mpysiak
force-pushed
the
SYL-3807-locale-switcher
branch
from
e3b0bc3 to
dd84bfc
Compare
Wojdylak
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.