Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shop] Product show #16748

Merged
merged 24 commits into from
Aug 23, 2024
Merged

[Shop] Product show #16748

merged 24 commits into from
Aug 23, 2024

Conversation

mpysiak
Copy link
Member

@mpysiak mpysiak commented Aug 20, 2024

Q A
Branch? bootstrap-shop
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
License MIT

@mpysiak mpysiak requested review from a team as code owners August 20, 2024 11:48
@probot-autolabeler probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Aug 20, 2024
@mpysiak mpysiak force-pushed the SYL-3701-product-show branch 3 times, most recently from b1fb434 to 9779a62 Compare August 20, 2024 11:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@mpysiak mpysiak force-pushed the SYL-3701-product-show branch 2 times, most recently from 8e393bd to 47cc8da Compare August 21, 2024 05:48
Wojdylak
Wojdylak reviewed Aug 21, 2024
View reviewed changes
src/Sylius/Bundle/ShopBundle/Resources/config/services/twig/component.xml
@@ -89,5 +89,57 @@
template="@SyliusShop/product/common/original_price.html.twig"
/>
</service>

<service
id="sylius_shop.twig.component.product_summary"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id="sylius_shop.twig.component.product_summary"
id="sylius_shop.twig.component.product.product_summary"

or, if you rename ProductSummaryComponent to SummaryComponent

Suggested change
id="sylius_shop.twig.component.product_summary"
id="sylius_shop.twig.component.product.summary"

src/Sylius/Bundle/ShopBundle/templates/product/show/page/info/summary.html.twig Show resolved Hide resolved
src/Sylius/Bundle/ShopBundle/Resources/config/services/twig/component.xml

<tag
name="sylius.live_component"
key="sylius_shop:product:show_summary"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key="sylius_shop:product:show_summary"
key="sylius_shop:product:summary"

or

Suggested change
key="sylius_shop:product:show_summary"
key="sylius_shop:product:show:summary"

src/Sylius/Bundle/ShopBundle/Resources/config/services/twig/component.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Product/AddToCart/FormComponent.php Outdated Show resolved Hide resolved
...lius/Bundle/ShopBundle/templates/product/show/page/info/summary/catalog_promotions.html.twig Outdated Show resolved Hide resolved
src/Sylius/Bundle/ShopBundle/Twig/Component/Product/AddToCart/FormComponent.php Outdated
#[LiveAction]
public function variantChanged(): void
{
$this->emit('sylius:shop:variant_changed', ['productVariantCode' => $this->formValues['cartItem']['variant']]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should create a constant for the event name 'sylius:shop:variant_changed'

@mpysiak mpysiak force-pushed the SYL-3701-product-show branch 2 times, most recently from 1c91a13 to b26e212 Compare August 21, 2024 08:03
@mpysiak mpysiak force-pushed the SYL-3701-product-show branch 2 times, most recently from 05cdb55 to b147e33 Compare August 22, 2024 07:46
@mpysiak mpysiak force-pushed the SYL-3701-product-show branch from 07ba6a4 to 395f36b Compare August 22, 2024 10:58
@GSadee GSadee merged commit 7d68b6e into Sylius:bootstrap-shop Aug 23, 2024
19 checks passed
@GSadee GSadee mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMilek TheMilek TheMilek left review comments

@Wojdylak Wojdylak Wojdylak approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Shop ShopBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpysiak @GSadee @Wojdylak @TheMilek