Organization of Commands/Messages #16642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Wojdylak
commented
Jul 29, 2024
Wojdylak
commented
| Q | A |
|---|---|
| Branch? | 2.0 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | #15730 |
| License | MIT |
probot-autolabeler
bot
added
Admin
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
force-pushed
the
organization-of-commands-messages
branch
from
9d65915 to
ea040b2
Compare
Wojdylak
force-pushed
the
organization-of-commands-messages
branch
from
ea040b2 to
a2f0573
Compare
src/Sylius/Bundle/CoreBundle/Resources/config/services/command_handler.xml
Outdated
Show resolved
Hide resolved
diimpp
previously requested changes
Aug 1, 2024
...e/Tests/DependencyInjection/Compiler/BackwardsCompatibility/ReplaceEmailManagersPassTest.php
Outdated
Show resolved
Hide resolved
...us/Bundle/CoreBundle/spec/CommandHandler/Admin/Account/SendResetPasswordEmailHandlerSpec.php
Outdated
Show resolved
Hide resolved
...us/Bundle/CoreBundle/Resources/config/serialization/Messages/Admin/Account/ResetPassword.xml
Outdated
Show resolved
Hide resolved
diimpp
reviewed
Aug 2, 2024
probot-autolabeler
bot
added
the
Maintenance
GSadee
approved these changes
Aug 5, 2024
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd" | ||
| > | ||
| <services> | ||
| <service id="sylius.command_dispatcher.resend_order_confirmation_email" class="Sylius\Bundle\CoreBundle\CommandDispatcher\ResendOrderConfirmationEmailDispatcher"> |
There was a problem hiding this comment.
I wonder if it would not be good to introduce these new ids already in version 1.14, and here just remove the deprecated (old) ones 🤔
Wojdylak
added a commit
that referenced
this pull request
Aug 6, 2024
| Q | A |-----------------|----- | Branch? | api-platform-3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | after #16642 | License | MIT <!-- - Bug fixes must be submitted against the 1.13 branch - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.