Implement hooks for checkout #16636
Merged
Implement hooks for checkout #16636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
reviewed
Jul 26, 2024
| {% block title %}{{ 'sylius.ui.address'|trans }} | {{ parent() }}{% endblock %} | ||
| {% block content_title %}{{ 'sylius.ui.address'|trans }}{% endblock %} | ||
| {% set form = hookable_metadata.context.form %} | ||
| {% set order = hookable_metadata.context.order %} |
There was a problem hiding this comment.
Why do you need the order here?
Comment on lines
4
to
5
| {% set taxIncluded = order.getTaxIncludedTotal() %} | ||
| {% set taxExcluded = order.getTaxExcludedTotal() %} |
There was a problem hiding this comment.
Suggested change
| {% set taxIncluded = order.getTaxIncludedTotal() %} | |
| {% set taxExcluded = order.getTaxExcludedTotal() %} | |
| {% set tax_included = order.getTaxIncludedTotal() %} | |
| {% set tax_excluded = order.getTaxExcludedTotal() %} |
| {% import "@SyliusShop/shared/macro/money.html.twig" as money %} | ||
|
|
||
| {% set order = hookable_metadata.context.order %} | ||
| {% set itemsSubtotal = order.getItemsSubtotal() %} |
There was a problem hiding this comment.
Suggested change
| {% set itemsSubtotal = order.getItemsSubtotal() %} | |
| {% set items_subtotal = order.getItemsSubtotal() %} |
|
|
||
| {% set item = hookable_metadata.context.item %} | ||
|
|
||
| <td id="{{ item.variant.product.slug }}" {{ sylius_test_html_attribute('item-subtotal', item.variant.product.slug) }}> |
There was a problem hiding this comment.
Suggested change
| <td id="{{ item.variant.product.slug }}" {{ sylius_test_html_attribute('item-subtotal', item.variant.product.slug) }}> | |
| <td {{ sylius_test_html_attribute('item-subtotal', item.variant.product.code) }}> |
| @@ -0,0 +1,7 @@ | |||
| {% set item = hookable_metadata.context.item %} | |||
|
|
|||
| <td {{ sylius_test_html_attribute('item-subtotal-quantity', item.variant.product.name) }}> | |||
There was a problem hiding this comment.
Suggested change
| <td {{ sylius_test_html_attribute('item-subtotal-quantity', item.variant.product.name) }}> | |
| <td {{ sylius_test_html_attribute('item-subtotal-quantity', item.variant.product.code) }}> |
Didn't check how it's used in behat, but I'm wondering if we shouldn't base the attribute on variant instead of the product
| {% set order = hookable_metadata.context.order %} | ||
|
|
||
| <table class="table table-borderless mb-3"> | ||
| {% hook 'total_costs' with { order } %} |
There was a problem hiding this comment.
Suggested change
| {% hook 'total_costs' with { order } %} | |
| {% hook 'totals' with { order } %} |
Same with the file name, using costs when we also have promotions inside seems weird.
Having it just as totals is more ambiguous.
|
|
||
| <tr> | ||
| <td>{{ 'sylius.ui.items_total'|trans }}:</td> | ||
| <td class="text-end">{{ money.convertAndFormat(itemsSubtotal) }}</td> |
There was a problem hiding this comment.
Suggested change
| <td class="text-end">{{ money.convertAndFormat(itemsSubtotal) }}</td> | |
| <td class="text-end">{{ money.convertAndFormat(order.itemsSubtotal) }}</td> |
To be more inline with the files below
kulczy
force-pushed
the
SYL-3751/hooks-checkout-address
branch
from
6350f3c to
2c0a938
Compare
NoResponseMate
approved these changes
Aug 2, 2024
GSadee
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Are these checkout events still needed?
Comment on lines
4
to
6
| {% include '@SyliusShop/checkout/address/form/addresses/shipping_address_required.html.twig' %} | ||
| {% else %} | ||
| {% include '@SyliusShop/checkout/address/form/addresses/billing_address_required.html.twig' %} |
There was a problem hiding this comment.
These includes should be converted into Twig Hooks, and ideally all address fields should be divided into separate templates so that this can be customized as easily as possible
kulczy
force-pushed
the
SYL-3751/hooks-checkout-address
branch
from
2c0a938 to
fd60922
Compare
kulczy
force-pushed
the
SYL-3751/hooks-checkout-address
branch
from
fd60922 to
089a90f
Compare
Wojdylak
approved these changes
Aug 8, 2024
NoResponseMate
approved these changes
Aug 8, 2024
|
Thank you, @kulczy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.