[API] Refactor QueryExtensions #16573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Jul 12, 2024
NoResponseMate
commented
| Q | A |
|---|---|
| Branch? | api-platform-3 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
reviewed
Jul 15, 2024
src/Sylius/Bundle/ApiBundle/Doctrine/ORM/QueryExtension/Shop/Order/ShopUserBasedExtension.php
Show resolved
Hide resolved
mpysiak
approved these changes
Jul 15, 2024
GSadee
approved these changes
Jul 16, 2024
Comment on lines
-28
to
+30
| /** @param array<string> $orderStatesToFilterOut */ | ||
| /** | ||
| * @param array<string> $orderStatesToFilterOut | ||
| */ |
There was a problem hiding this comment.
Why? I am in favour of the single-line version 😅
Wojdylak
added a commit
that referenced
this pull request
Jul 17, 2024
| Q | A |-----------------|----- | Branch? | api-platform-3 <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | License | MIT <!-- - Bug fixes must be submitted against the 1.13 branch - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> [REF](#16573)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.